-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: All AWS services emit traces #1150
Merged
kaylareopelle
merged 12 commits into
open-telemetry:main
from
jterapin:aws-sdk-v3-support-all-services
Sep 18, 2024
Merged
feat: All AWS services emit traces #1150
kaylareopelle
merged 12 commits into
open-telemetry:main
from
jterapin:aws-sdk-v3-support-all-services
Sep 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jterapin
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
arielvalentin,
ahayworth,
plantfansam,
robbkidd,
simi,
kaylareopelle and
xuan-cao-swi
as code owners
September 5, 2024 17:42
alextwoods
reviewed
Sep 5, 2024
instrumentation/aws_sdk/lib/opentelemetry/instrumentation/aws_sdk/instrumentation.rb
Outdated
Show resolved
Hide resolved
instrumentation/aws_sdk/lib/opentelemetry/instrumentation/aws_sdk/instrumentation.rb
Outdated
Show resolved
Hide resolved
instrumentation/aws_sdk/lib/opentelemetry/instrumentation/aws_sdk/instrumentation.rb
Outdated
Show resolved
Hide resolved
instrumentation/aws_sdk/lib/opentelemetry/instrumentation/aws_sdk/instrumentation.rb
Outdated
Show resolved
Hide resolved
instrumentation/aws_sdk/lib/opentelemetry/instrumentation/aws_sdk/messaging_helper.rb
Outdated
Show resolved
Hide resolved
jterapin
changed the title
feat: All V3 services emit traces
feat: All AWS services emit traces
Sep 5, 2024
instrumentation/aws_sdk/lib/opentelemetry/instrumentation/aws_sdk/handler.rb
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks really good! Thank you so much for your contribution. I have one small question before approval.
instrumentation/aws_sdk/lib/opentelemetry/instrumentation/aws_sdk/instrumentation.rb
Outdated
Show resolved
Hide resolved
…/opentelemetry-ruby-contrib into aws-sdk-v3-support-all-services
kaylareopelle
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @jterapin! 🎉
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Currently, only AWS services outlined here can emit tracing. This PR ensures that all AWS services are supported.
Other changes:
MessagingHelper
and the existingHandler
in preparation to integrate the AWS SDK for Ruby Observability support.